Skip to content

[SYCL] Allow for local/image accessor to accept property_list #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maximdimakov
Copy link
Contributor

@maximdimakov maximdimakov commented Feb 1, 2021

Added "property_list" parameter to the local/image accessor constructors accordingly to the specification. The parameter is not used anywhere so it was added as dummy parameter only to match the specification
The test for this PR: intel/llvm-test-suite#132

Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
@maximdimakov maximdimakov requested a review from s-kanaev February 1, 2021 14:10
@maximdimakov maximdimakov requested a review from a team as a code owner February 1, 2021 14:10
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
@s-kanaev
Copy link
Contributor

s-kanaev commented Feb 2, 2021

@maximdimakov, could you, please, provide a more meaningful summary of the PR?

Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
Signed-off-by: mdimakov <maxim.dimakov@intel.com>
@maximdimakov maximdimakov changed the title Fix local/image accessor constructors [SYCL] Allow for local/image accessor to accept property_list Feb 2, 2021
@romanovvlad romanovvlad merged commit 88fab25 into intel:sycl Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants