[SYCL] Refactor the way we diagnose some SYCL attributes; mostly NFC #3147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a helper method from some SYCL attributes which would provide the name of the attribute. This code wasn't needed because the diagnostics engine already knows how to print attributes by name. While making this change, some diagnostics are now properly quoted when they weren't previously. As a drive-by, I also noticed that the location of the diagnostics was wrong (it was diagnosing the start of the attribute range rather than the problematic attribute). This means that duplicate or conflicting attributes should be warning about the second attribute (the one causing the conflict) rather than the first attribute.
AaronBallman
requested review from
elizabethandrews and
premanandrao
as code owners
|
Nice change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a helper method from some SYCL attributes which would
provide the name of the attribute. This code wasn't needed because the
diagnostics engine already knows how to print attributes by name.
While making this change, some diagnostics are now properly quoted when
they weren't previously. As a drive-by, I also noticed that the location
of the diagnostics was wrong (it was diagnosing the start of the
attribute range rather than the problematic attribute). This means that
duplicate or conflicting attributes should be warning about the second
attribute (the one causing the conflict) rather than the first
attribute.