-
Notifications
You must be signed in to change notification settings - Fork 799
[SYCL][Doc] Clarify environment variables documentation #4640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| -------------------- | ------ | ----------- | | ||
| `SYCL_ENABLE_PCI` | Integer | When set to 1, enables obtaining the GPU PCI address when using the Level Zero backend. The default is 0. | | ||
| `SYCL_PI_LEVEL_ZERO_DISABLE_USM_ALLOCATOR` | Any(\*) | Disable USM allocator in Level Zero plugin (each memory request will go directly to Level Zero runtime) | | ||
| `SYCL_PI_LEVEL_ZERO_TRACK_INDIRECT_ACCESS_MEMORY` | Any(\*) | Enable support of the kernels with indirect access and corresponding deferred release of memory allocations in the Level Zero plugin. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smaslov-intel
Could you please tell if we have tests for this variable(couldn't find such)? If no, probably we need to move it to "debugging" section until we have proper testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@againull : did you add a test?
sycl/doc/EnvironmentVariables.md
Outdated
|
||
**Warning:** the environment variables described below are used for | ||
development and debugging of DPC++ compiler and runtime. Their semantics are | ||
subject to change. Do not rely on these variables in production code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would stop more people from using these vars if we say that they may have bugs that we may refuse to fix. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're not bugs, they're undefined behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except the comment about L0 env var above.
sycl/doc/EnvironmentVariables.md
Outdated
|
||
## Debugging variables for DPC++ Runtime | ||
|
||
**Warning:** the environment variables described below are used for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we highlight this warning more? Red text or some warning icon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This blocks color painting on github: github/markup#1440 (but it'll work for rendered docs)
But github supports emojis, so I added one
sycl/doc/EnvironmentVariables.md
Outdated
**Warning:** the environment variables described below are used for | ||
development and debugging of DPC++ compiler and runtime. Their semantics are | ||
subject to change. Do not rely on these variables in production code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
This patch splits up environment variables into 4 categories, to make it clear, which variables are not supposed to be used in production and only serve for debugging purpose.