[SYCL][LIBCLC] Add support for shuffles in AMDGCN. #4664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of how HIP implements shuffles with types adjusted for OpenCL builtin types.
|
Enabling of the test in the test suite repo: intel/llvm-test-suite#487 |
bader
added
libclc
|
Ping @bader , the tests went in, so it'd be good to have this merged soon as well. |
bader
previously approved these changes
Oct 5, 2021
| return as_uint( | ||
| _Z28__spirv_SubgroupShuffleINTELIiET_S0_j(as_int(Data), InvocationId)); | ||
| } | ||
| // Sub 32-bit types. |
There was a problem hiding this comment.
I think it's probably make sense to add similar macro functions for 32-bit types (int, unsigned int and float) and 64-bit types (long, unsigned long and double) to avoid code duplication.
There was a problem hiding this comment.
That's a good point, done in: d6ffcf3.
Looks like there could be another layer of macros (split per number of arguments), but I worry it would make this file too cryptic.
bader
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings support for the following builtins:
For all the types (modulo half, as it is not supported across all the AMD's targets in libspirv).