[SYCL][CUDA] Skip target options when preprocessing. #4805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchlanda
requested review from
AGindinson,
hchilama and
mdtoguchi
as code owners
AGindinson
reviewed
Oct 23, 2021
Co-authored-by: Artem Gindinson <artem.gindinson@intel.com>
My bad, sorry. Added now. |
bader
previously approved these changes
Oct 25, 2021
AGindinson
reviewed
Oct 25, 2021
AGindinson
reviewed
Oct 26, 2021
AGindinson
reviewed
Oct 26, 2021
|
Looks like I was to hasty with the early return, there are tests that rely on the code happening afterwards. The problem is more fundamental and to do with the fact that not all actions get the default bound arch propagated. I'm closing this PR and will have to look into the bound arch more. |
dm-vodopyanov
pushed a commit
that referenced
this pull request
Nov 9, 2021
With this patch the bound arch is correctly propagated through the phases:
```
+- 0: input, "./../tickets/dashE/woof.cpp", c++, (device-sycl, sm_50)
+- 1: preprocessor, {0}, c++-cpp-output, (device-sycl, sm_50)
+- 2: offload, "device-sycl (nvptx64-nvidia-cuda:sm_50)" {1}, c++-cpp-output
| +- 3: input, "./../tickets/dashE/woof.cpp", c++, (host-sycl)
| |- 4: compiler, {1}, none, (device-sycl, sm_50)
| +- 5: offload, "host-sycl (x86_64-unknown-linux-gnu)" {3}, "device-sycl (nvptx64-nvidia-cuda:sm_50)" {4}, c++
| +- 6: append-footer, {5}, c++, (host-sycl)
|- 7: preprocessor, {6}, c++-cpp-output, (host-sycl)
8: clang-offload-bundler, {2, 7}, c++-cpp-output, (host-sycl)
```
Previously the `compiler` phase (`4`) was lacking the bound arch, which is the root cause of #4758:
```
|- 4: compiler, {1}, none, (device-sycl)
```
Resolves: #4758
Previous discussion in: #4805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4758