[NFC][SYCL] Add/Remove punctuation

[elizabethandrews]

Change diagnostic punctuation to be consistent with Clang
diagnostics

Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com

[smanna12]

Thanks for the change.

[premanandrao]

Are there no tests affected by this? That's a bit surprising.

[elizabethandrews]

Are there no tests affected by this? That's a bit surprising.

The tests only check for the first half of diagnostic. So it doesn't fail

[premanandrao]

Are there no tests affected by this? That's a bit surprising.

The tests only check for the first half of diagnostic. So it doesn't fail

Could we expand what it checks? It seems that the latter part of diagnostics can "slip by" otherwise.

[elizabethandrews]

Are there no tests affected by this? That's a bit surprising.

The tests only check for the first half of diagnostic. So it doesn't fail

Could we expand what it checks? It seems that the latter part of diagnostics can "slip by" otherwise.

I can do that. We do have a lot of tests written this way in Clang though - where you don't check the entire diagnostic because checking the first part is enough to ensure the diagnostic has been emitted. Do you want to start enforcing this in reviews going forward? I don't at the moment since it is existing practice, and personally don't feel it is required

[premanandrao]

Are there no tests affected by this? That's a bit surprising.

The tests only check for the first half of diagnostic. So it doesn't fail

Could we expand what it checks? It seems that the latter part of diagnostics can "slip by" otherwise.

I can do that. We do have a lot of tests written this way in Clang though - where you don't check the entire diagnostic because checking the first part is enough to ensure the diagnostic has been emitted. Do you want to start enforcing this in reviews going forward? I don't at the moment since it is existing practice, and personally don't feel it is required

What do you think about having at least one place where a diagnostic is checked in its entirety (with wildcards where appropriate), but elsewhere just enough to verify its emission, for convenience? @smanna12, your thoughts?

[smanna12]

Are there no tests affected by this? That's a bit surprising.

The tests only check for the first half of diagnostic. So it doesn't fail

Could we expand what it checks? It seems that the latter part of diagnostics can "slip by" otherwise.

I can do that. We do have a lot of tests written this way in Clang though - where you don't check the entire diagnostic because checking the first part is enough to ensure the diagnostic has been emitted. Do you want to start enforcing this in reviews going forward? I don't at the moment since it is existing practice, and personally don't feel it is required

What do you think about having at least one place where a diagnostic is checked in its entirety (with wildcards where appropriate), but elsewhere just enough to verify its emission, for convenience? @smanna12, your thoughts?

I personally feel to check the entire diagnostic. In case we update the diag, it would be easier to verify its emission with complete one for convenience .

[elizabethandrews]

Are there no tests affected by this? That's a bit surprising.

The tests only check for the first half of diagnostic. So it doesn't fail

Could we expand what it checks? It seems that the latter part of diagnostics can "slip by" otherwise.

I can do that. We do have a lot of tests written this way in Clang though - where you don't check the entire diagnostic because checking the first part is enough to ensure the diagnostic has been emitted. Do you want to start enforcing this in reviews going forward? I don't at the moment since it is existing practice, and personally don't feel it is required

What do you think about having at least one place where a diagnostic is checked in its entirety (with wildcards where appropriate), but elsewhere just enough to verify its emission, for convenience? @smanna12, your thoughts?

I personally feel to check the entire diagnostic. In case we update the diag, it would be easier to verify its emission with complete one for convenience .

Done. I added the full diagnostic. Thanks for the review!

[smanna12]

Thanks for the changes.

[premanandrao]

Thank you for the changes, LGTM