[sycl-post-link][NFC] Outline legacy tests #4844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved a number of `sycl-post-link` LIT tests for specialization constants into a separate folder: those tests are using old RT-Compiler interface, which is only used for experimental support for spec constants in SYCL 1.2.1. That old version of spec constants depends on `program` class, which was removed from SYCL 2020 specification and from our implementation. Therefore, support for old spec constants API is not available anymore. The API itself is still supported for backward compatibility, but it will be completly erased at some point. This patch will simplify tests cleanup when backward compatibility break will be done.
|
I plan to submit a separate PR, which will bring up to date equivalents of tests, which are declared |
kbobrovs
reviewed
Oct 29, 2021
Good point, renamed directory in e855808 |
vmaksimo
approved these changes
Oct 29, 2021
kbobrovs
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved a number of
sycl-post-linkLIT tests for specializationconstants into a separate folder: those tests are using old RT-Compiler
interface, which is only used for experimental support for spec
constants in SYCL 1.2.1.
That old version of spec constants depends on
programclass, which wasremoved from SYCL 2020 specification and from our implementation.
Therefore, support for old spec constants API is not available anymore.
The API itself is still supported for backward compatibility, but it
will be completly erased at some point. This patch will simplify tests
cleanup when backward compatibility break will be done.