[Driver][SYCL] Set default device code split mode to off for FPGA #4893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qichao Gu <qichao.gu@intel.com>
qichaogu
requested review from
AGindinson,
hchilama and
mdtoguchi
as code owners
|
This looks the same as #4447 - I would assume you just want to use this one instead. |
mdtoguchi
approved these changes
Nov 4, 2021
hchilama
approved these changes
Nov 4, 2021
|
@intel/llvm-gatekeepers Could you help merge? |
mlychkov
added a commit
to mlychkov/llvm-test-suite
that referenced
this pull request
Dec 1, 2021
Patch intel/llvm#4893 turned off device code splitting for FPGA target by default. That in turn unblocked use of functions from device libraries. Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Dec 5, 2021
Patch intel/llvm#4893 turned off device code splitting for FPGA target by default. That in turn unblocked use of functions from device libraries. Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…te#592) Patch intel#4893 turned off device code splitting for FPGA target by default. That in turn unblocked use of functions from device libraries. Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Driver passes default device code split mode (-split=auto) to
sycl-post-link when -fsycl-device-code-split is not set. This should
not be applied for FPGA, because FPGA is using SYCL_EXTERNAL for
some of their library configurations but auto device code split mode
impacts this behavior.
Signed-off-by: Qichao Gu qichao.gu@intel.com