Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][XPTI] Add accessor events #5249

Merged
merged 9 commits into from Jan 4, 2022
Merged

[SYCL][XPTI] Add accessor events #5249

merged 9 commits into from Jan 4, 2022

Conversation

vladimirlaz
Copy link
Contributor

@vladimirlaz vladimirlaz commented Dec 30, 2021 •
edited

  • Accessor construction events using the following APIs covering all targets and modes:
    • sycl::buffer::get_access();
    • sycl::accessor constructors;
  • Fixed XPTI hash generation (added previously missed dependency on source code location line number).

E2E tests: intel/llvm-test-suite#700

@vladimirlaz vladimirlaz requested a review from a team as a code owner December 30, 2021 15:06
@vladimirlaz vladimirlaz mentioned this pull request Jan 3, 2022
Merged
cperkinsintel
cperkinsintel approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the llvm-test-suite update (intel/llvm-test-suite#700) against this PR on my dev machine and the tests pass there.

LGTM.

@vladimirlaz vladimirlaz merged commit 9eb7a30 into intel:sycl Jan 4, 2022
@vladimirlaz
Copy link
Contributor Author

E2E tests (intel/llvm-test-suite#700) should be merged once nightly is ready.

@vladimirlaz vladimirlaz deleted the xpti_advisor_events branch January 11, 2022 06:26
s-kanaev
s-kanaev reviewed Jan 11, 2022
View reviewed changes
sycl/source/detail/xpti_registry.hpp
static void bufferAccessorNotification(void *UserObj, void *AccessorObj,
uint32_t Target, uint32_t Mode,
const detail::code_location &CodeLoc);
static xpti::trace_event_data_t *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, this should be guarded with XPTI_ENABLE_INSTRUMENTATION. Otherwise it breaks non-xpti builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-kanaev s-kanaev s-kanaev left review comments

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@v-klochkov v-klochkov Awaiting requested review from v-klochkov v-klochkov is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vladimirlaz @cperkinsintel @s-kanaev