[LIBCLC][HIP] Add HIP AMD support for ilogb, log2, remainder

[hdelan]

Fixing bug due to incorrect naming of remainder.cl as remainer.cl.

[AerialMantis]

@bader could we get another review on this one? I also see that one of the CI jobs failed but the failure doesn't seem related, would you be able to re-run the CI.

[bader]

@bader could we get another review on this one? I also see that one of the CI jobs failed but the failure doesn't seem related, would you be able to re-run the CI.

I did this a few weeks ago and it failed after re-run. I just re-started CI jobs again, let's see if it passes on third attempt. If not, I would recommend pulling sycl branch to https://github.com/hdelan/llvm/tree/hugh/libclc_amd.

I missed the review because it's doesn't show up on my GitHub dashboard - https://github.com/pulls/review-requested. I would appreciate if you can request via GitHub UI.

Let me know if it's not available for you. I usually track PRs where my review is explicitly requested. It's hard to track all PRs.

[bader]

The test still fails. @hdelan, could you update the branch, please?

[hdelan]

Branch updated! Sorry for delay

[AerialMantis]

Thanks @bader no worries, yeah I can do that instead, though I don't see that option, maybe only the author of the PR can see that?

[bader]

I don't see that option, maybe only the author of the PR can see that?

Do you see that option in closed PR or you don't see in in open PRs as well? Do you see it here: #5303?

[AerialMantis]

Okay yeah I can see it on that one, I did check another open PR but I think it only shows if there's been changes since that person's reviews, thanks :)