Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix module changes detection in LowerWGScope pass #5292

Merged
merged 3 commits into from Jan 17, 2022
Merged

[SYCL] Fix module changes detection in LowerWGScope pass #5292

merged 3 commits into from Jan 17, 2022

Conversation

mlychkov
Copy link
Contributor

@mlychkov mlychkov commented Jan 12, 2022 •
edited

Some changes performed by LowerWGScope pass don't reset analyses state.
This lack of detection is caught by new Pass Manager.
Fix LowerWGScope pass changes detection. Also add execution with both legacy and
new Pass Managers into LIT tests that were failed on new PM without this fix.

@mlychkov mlychkov requested a review from a team as a code owner January 12, 2022 13:28
@mlychkov
Update LIT tests affected by incorrect changes detection in new PM
4658b4f 
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@mlychkov
Copy link
Contributor Author

The full set of fixes for new PM also validated in #4860.

kbobrovs
kbobrovs approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexeySachkov
Copy link
Contributor

AlexeySachkov commented Jan 17, 2022 •
edited 

Failed Tests (3):
  SYCL :: SubGroup/broadcast.cpp
  SYCL :: SubGroup/broadcast_fp16.cpp
  SYCL :: SubGroup/broadcast_fp64.cpp

Failed tests on HIP were marked as expected to fail in intel/llvm-test-suite#740

@AlexeySachkov AlexeySachkov merged commit 34d64cf into intel:sycl Jan 17, 2022
@mlychkov mlychkov deleted the private/mlychkov/fix_changes_select_in_lowerwgscope_pass branch January 18, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@kbobrovs kbobrovs kbobrovs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlychkov @AlexeySachkov @kbobrovs