Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NewPM] Add SPIRITTAnnotations pass into optimization #5300

Merged

Conversation

mlychkov
Copy link
Contributor

Add SPIRITTAnnotations pass into clang optimizations pipeline when using
new Pass Manager.

Signed-off-by: Mikhail Lychkov mikhail.lychkov@intel.com

Add SPIRITTAnnotations pass into clang optimizations pipeline when using
new Pass Manager.

Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@mlychkov mlychkov requested a review from a team as a code owner January 13, 2022 09:35
@mlychkov
Copy link
Contributor Author

The full set of fixes for new PM also validated in #4860.

@mlychkov mlychkov marked this pull request as draft January 15, 2022 11:41
@mlychkov
Copy link
Contributor Author

Temporary moved to draft while #5315 is not merged.

Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@mlychkov mlychkov marked this pull request as ready for review January 18, 2022 05:55
AlexeySachkov
AlexeySachkov previously approved these changes Jan 18, 2022
Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Co-authored-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
smanna12
smanna12 previously approved these changes Jan 18, 2022
Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
MrSidims
MrSidims previously approved these changes Jan 18, 2022
@mlychkov mlychkov dismissed stale reviews from MrSidims and smanna12 via f139546 January 18, 2022 20:05
smanna12
smanna12 previously approved these changes Jan 18, 2022
@mlychkov
Copy link
Contributor Author

mlychkov commented Jan 19, 2022

All failed tests are known issues and don't relate to current change.

@AlexeySachkov
Copy link
Contributor

All failed tests are known issues and don't relate to current change.

Do we have issues submitted about them? Are there any PRs with fixes or disabling of those tests?

@bader
Copy link
Contributor

bader commented Jan 20, 2022

@mlychkov, please, resolve merge conflicts.

@mlychkov
Copy link
Contributor Author

All failed tests are known issues and don't relate to current change.

Do we have issues submitted about them? Are there any PRs with fixes or disabling of those tests?

Issues for similar tests were closed or related to another configurations.
New issues for current fails have been created.

@bader bader merged commit 10c629a into intel:sycl Jan 22, 2022
@mlychkov mlychkov deleted the private/mlychkov/newPM_add_itt_annot_pass_to_codegen branch January 25, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants