Skip to content

[SYCL][DOC] Clarification to device global design #5432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Jan 31, 2022

Clarify which SPIR-V decorations the sycl-post-link tool generates
for each device global variable. Also update the link to the
compile-time property design, which is now merged.

Clarify which SPIR-V decorations the `sycl-post-link` tool generates
for each device global variable.  Also update the link to the
compile-time property design, which is now merged.
@gmlueck gmlueck requested a review from a team as a code owner January 31, 2022 14:05
@gmlueck
Copy link
Contributor Author

gmlueck commented Feb 1, 2022

@steffenlarsen: Ping. Could you review this please? Thanks!

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarification. LGTM!

@bader bader merged commit 3c3b485 into intel:sycl Feb 1, 2022
@gmlueck gmlueck deleted the gmlueck/clarify-device-global-design branch February 1, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants