[Matrix][SYCL] Fix the bug of comparison between two bf16's wi_element #5493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yubingex007-a11y
requested review from
s-kanaev,
dkhaldi,
LuoYuanke and
AlexeySotkin
|
@intel/llvm-reviewers-runtime ping |
yubingex007-a11y
commented
Feb 8, 2022
| @@ -477,8 +477,8 @@ class wi_element<uint16_t, NumRows, NumCols, Layout, Group> { | |||
|
|
|||
| explicit operator bool() { | |||
| #ifdef __SYCL_DEVICE_ONLY__ | |||
| return __spirv_VectorExtractDynamic(M.spvm, idx) != | |||
| static_cast<uint16_t>(0); | |||
| return std::fabs(make_fp32(__spirv_VectorExtractDynamic(M.spvm, idx))) < | |||
There was a problem hiding this comment.
it seems element_wise_all_ops_bf16_yubing_20220128.cpp failed on this line.
when I change to
make_fp32(__spirv_VectorExtractDynamic(M.spvm, idx)) != 0.0f;
the testcase can pass
@AlexeySotkin , what should we do for operator bool()?
There was a problem hiding this comment.
we use ">=" instead of "<"
|
ping? @dkhaldi |
|
@intel/llvm-reviewers-runtime ping |
vladimirlaz
approved these changes
Feb 9, 2022
|
@vladimirlaz , hi, could you help us merge it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, as for bf16's comparison, we directly compare two unsigned short and it is wrong.
Now, we extend b16 to float and do the correct comparsion.