[SYCL] Implements initial device_global registration #5499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add required interface for the integration footer to register the `device_global` of a program as well as reading the extended information supplied by sycl-post-link through the "SYCL/device globals" property. The information is stored in a map managed by the program manager. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
ghost
previously approved these changes
Feb 8, 2022
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
steffenlarsen
dismissed stale reviews from ghost
and cperkinsintel
via
126693a
ghost
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
LGTM, thank you @steffenlarsen for the comment, it's crystal clear now
cperkinsintel
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add required interface for the integration footer to register the
device_globalof a program as well as reading theextended information supplied by sycl-post-link through the "SYCL/device globals" property. The information is stored in a map
managed by the program manager.
Note that this is the first change to the runtime relating to
device_globaland as such the feature is not complete nor fully testable. It simply intents to add an interface for the integration footer as well as a consumer for the information sycl-post-link will be generating when future work is added.See sycl/doc/DeviceGlobal.md.