Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD] Add support for dpas API #5637

Merged
merged 1 commit into from Feb 24, 2022

Conversation

sndmitriev
Copy link
Contributor

Signed-off-by: Sergey Dmitriev serguei.n.dmitriev@intel.com

Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
@sndmitriev sndmitriev requested a review from a team as a code owner February 23, 2022 04:34
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch has been reviewed internally, so this LGTM.
Please add an E2E test.

For the record: this is an initial bring-up of DPAS APIs, to enable earlier use/trial. Interface refactoring is planned, which will e.g. get rif of the precision template arguments, and it will be possible to use

  simd<N, bfloat16> arg;
  simd<N, bfloat16> x = dpas<...>(...arg...)

instead of

  simd<N, bfloat16> arg;
  simd<N, uint16_t> x = dpas<...argument_type::BF16...>(...arg.data()...)

@kbobrovs kbobrovs merged commit 5881938 into intel:sycl Feb 24, 2022
@sndmitriev sndmitriev deleted the sndmitriev/esimd-dpas-api branch February 24, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants