[SYCL][DOC] Change device_global property definitions #5691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent change to the compile-time property extension, properties must follow a different structure and naming to the one used by the device_global extension. This commit makes the device_global extension adhere to the new requirements and adds additional non-template variants of templated properties, e.g. `host_access_read` as a shorthand for `host_access<host_access_enum::read>`. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
|
This looks good. Please also update the copyright notice to "2021 - 2022". |
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
gmlueck
previously approved these changes
Mar 1, 2022
|
Please change the dependencies section to say that this depends on sycl_ext_oneapi_properties now instead of sycl_ext_oneapi_property_list. |
|
@steffenlarsen, please, resolve merge conflicts. |
@steffenlarsen, could you address this comment too, please? |
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
|
Dependency name should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent change to the compile-time property extension, properties must follow a different structure and naming to the one used by the
device_globalextension. This commit makes thedevice_globalextension adhere to the new requirements and adds additional non-template variants of templated properties, e.g.host_access_readas a shorthand forhost_access<host_access_enum::read>.