Skip to content

[SYCL] Query USM buffer location extension only if property is passed to malloc_shared #6268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2022
Merged

[SYCL] Query USM buffer location extension only if property is passed to malloc_shared #6268

merged 1 commit into from
Jun 8, 2022

Conversation

pcolberg
Copy link
Contributor

@pcolberg pcolberg commented Jun 7, 2022

This aligns the implementation with malloc_host and avoids an unneeded
call in the case where the FPGA backend is used without buffer location.

This amends #6218

See also #6220

@pcolberg
[SYCL] Query USM buffer location extension only if property is passed…
5135b7e 
… to malloc_shared

This aligns the implementation with malloc_host and avoids an unneeded
call in the case where the FPGA backend is used without buffer location.

This amends #6218

See also #6220
@pcolberg pcolberg requested a review from a team as a code owner June 7, 2022 23:55
@pcolberg pcolberg requested a review from steffenlarsen June 7, 2022 23:55
@pcolberg
Copy link
Contributor Author

pcolberg commented Jun 8, 2022

@intel/llvm-reviewers-runtime This PR is ready for review.

steffenlarsen
steffenlarsen approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pcolberg
Copy link
Contributor Author

pcolberg commented Jun 8, 2022

Thanks @steffenlarsen for the quick reviews and merges 🙂

@pvchupin pvchupin merged commit 8c4d9a5 into intel:sycl Jun 8, 2022
@pcolberg pcolberg deleted the usm_malloc_shared_has_extension branch June 8, 2022 23:54
@pcolberg pcolberg mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees

@tiwaria1 tiwaria1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcolberg @steffenlarsen @pvchupin @tiwaria1