[SYCL][ABI-Break] Remove deprecated OptionalDevice input type of make_queue and remove deprecated make_queue ABIs #6628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byoungro So <byoungro.so@intel.com>
|
@bso-intel : please provide the description of this PR |
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
changed the title
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
changed the title
smaslov-intel
previously approved these changes
Sep 2, 2022
steffenlarsen
changed the title
|
@bso-intel - Looks like this patch breaks ABI. I've marked it as such, but it should increment |
Signed-off-by: Byoungro So <byoungro.so@intel.com>
steffenlarsen
previously approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Only changes since @smaslov-intel 's final approval is the increment of SYCL_DEV_ABI_VERSION. This should be ready for merge after testing finishes.
Signed-off-by: Byoungro So <byoungro.so@intel.com>
|
It seems the failures are irrelevant to my change of SYCL_DEV_ABI_VERSION number. |
steffenlarsen
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a tentative OptionalDevice input type of make_queue API to support the SYCL 2020 API as well as the legacy API which did not require Device to be passed as a parameter.
This PR intends to remove this tentative input type.
Extended: Now this PR also removed deprecated make_queue ABIs and make the make_queue to take a pointer to pi_device, which becomes back to optional.