[SYCL] Pass /Zc:__cplusplus in -fsycl-host-compiler-options in some tests #6751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests By default MSVC reports 199711L as the standard being used and needs that option to report C++ version properly. This fixes current post-commit failures on the tests modified.
|
llvm-test-suite :: fsycl-host-compiler.cpp failed on HIP and CUDA. It is unrelated because this PR only changes tests inside llvm project and has no effect on llvm-test-suite. Also, the same failures are observed on an unrelated PR at https://github.com/intel/llvm/runs/8275065891?check_suite_focus=true |
againull
approved these changes
Sep 9, 2022
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default MSVC reports 199711L as the standard being used and needs that
option to report C++ version properly. This fixes current post-commit
failures on the tests modified.