[SYCL] sub-devices selected by ONEAPI_DEVICE_SELECTOR as root devices #7167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm-test-suite#1346 |
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
steffenlarsen
approved these changes
Nov 3, 2022
steffenlarsen
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Nov 3, 2022
These are the tests for intel/llvm#7167 All devices available when using ONEAPI_DEVICE_SELECTOR are root devices, even those which are gotten via the sub-device selection choices ( e.g. ONEAPI_DEVICE_SELECTOR=level_zero:*.* ). In this PR we are ensuring that all devices gotten with that environment variable are root devices that have no parent. And, conversely, that when not using it, any sub-devices do report the correct parent.
|
@cperkinsintel - post-link is failing on macOS and Linux after merge. Could you please investigate? |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…-test-suite#1346) These are the tests for intel#7167 All devices available when using ONEAPI_DEVICE_SELECTOR are root devices, even those which are gotten via the sub-device selection choices ( e.g. ONEAPI_DEVICE_SELECTOR=level_zero:*.* ). In this PR we are ensuring that all devices gotten with that environment variable are root devices that have no parent. And, conversely, that when not using it, any sub-devices do report the correct parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All devices available when using ONEAPI_DEVICE_SELECTOR are root devices, even those which are gotten via the sub-device selection choices ( e.g.
ONEAPI_DEVICE_SELECTOR=level_zero:*.*). In this PR we are ensuring that those devices pretend to be root devices.Tests for this are here: intel/llvm-test-suite#1346