[NFC][SYCL][Reduction] Move "Out" accessor down to the implementation #7216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this changes we had regCGFunc implement the following dispatch
logic:
````
auto Out = [](){if constexpr (Cond) ... else ...}();
// ...
if constexpr (cond)
impl1(Out)
else
impl2(Out)
else
if constexpr (cond)
impl3(Out)
else
impl4(Out)
````
which means that the `Out` is very tightly coupled with particular
"impl" used. As such, it makes sense to sink it down to its usage.
v-klochkov
approved these changes
Oct 28, 2022
|
@intel/llvm-gatekeepers , this PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this changes we had regCGFunc implement the following dispatch logic:
which means that the
Outis very tightly coupled with particular "impl" used. As such, it makes sense to sink it down to its usage.