Skip to content

[SYCL] Allow ESIMD backend only when explicitly set by ONEAPI_DEVICE_SELECTOR #7336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2022
Merged

[SYCL] Allow ESIMD backend only when explicitly set by ONEAPI_DEVICE_SELECTOR #7336

merged 3 commits into from
Nov 10, 2022

Conversation

raaiq1
Copy link
Contributor

@raaiq1 raaiq1 commented Nov 9, 2022 •
edited
Loading

ONEAPI_DEVICE_SELECTOR would previously implicitly allow ESIMD backends . This isn't desired behavior; desired behavior is to only allow ESIMD backend only when explicitly specified by ONEAPI_DEVICE_SELECTOR.
Fix suggested by @lbushi25
Signed-off-by: Rauf, Rana rana.rauf@intel.com

@raaiq1
[SYCL] Allow ESIMD backend when explicitly set by ONEAPI_DEVICE_SELECTOR
c5c8a23 
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
@raaiq1 raaiq1 requested a review from a team as a code owner November 9, 2022 17:00
@raaiq1 raaiq1 requested a review from bso-intel November 9, 2022 17:00
@lbushi25 lbushi25 mentioned this pull request Nov 9, 2022
Merged
@raaiq1 raaiq1 mentioned this pull request Nov 9, 2022
Merged
@steffenlarsen steffenlarsen mentioned this pull request Nov 10, 2022
Merged
steffenlarsen
steffenlarsen requested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting doesn't seem to have been applied but lint hasn't complained, which is a little concerning. @raaiq1 - Could you please format the changes?

@pvchupin - Is this a know issue?

This was referenced Nov 10, 2022
Merged
Merged
@AlexeySachkov AlexeySachkov mentioned this pull request Nov 10, 2022
Merged
@steffenlarsen steffenlarsen mentioned this pull request Nov 10, 2022
Merged
@raaiq1
Formatting
5085783 
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
@raaiq1
Better
83f5545 
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
steffenlarsen
steffenlarsen approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@steffenlarsen steffenlarsen merged commit 1fda2a3 into intel:sycl Nov 10, 2022
@steffenlarsen steffenlarsen mentioned this pull request Nov 10, 2022
Merged
@Fznamznon Fznamznon mentioned this pull request Nov 10, 2022
Merged
@pvchupin
Copy link
Contributor

@pvchupin - Is this a know issue?

I'm not aware about this issue.

@pvchupin pvchupin mentioned this pull request Nov 10, 2022
Merged
@AlexeySachkov AlexeySachkov mentioned this pull request Nov 15, 2022
Merged
@raaiq1 raaiq1 deleted the ONEAPI_FIX branch November 15, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raaiq1 @pvchupin @steffenlarsen