Skip to content

[SYCL][PI][L0] Uplift L0 Loader from 1.4.1 to 1.8.8 #7381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

yanfeng3721
Copy link
Contributor

No description provided.

@yanfeng3721 yanfeng3721 requested a review from a team as a code owner November 14, 2022 07:34
@yanfeng3721 yanfeng3721 changed the title Uplift LO Loader from 1.4.1 to 1.8.8 Uplift L0 Loader from 1.4.1 to 1.8.8 Nov 14, 2022
@yanfeng3721
Copy link
Contributor Author

Failed Tests (1):
  SYCL :: Basic/barrier_order.cpp

Failed test is not related to current PR and due to #8798

@yanfeng3721 yanfeng3721 requested a review from bader November 15, 2022 05:08
@yanfeng3721
Copy link
Contributor Author

@bader , could you please help to merge the PR? Thanks.

@bader
Copy link
Contributor

bader commented Nov 15, 2022

@againull, is it okay to merge this PR? I see that you approved but haven't merged it.

@bader bader changed the title Uplift L0 Loader from 1.4.1 to 1.8.8 [SYCL][PI][L0] Uplift L0 Loader from 1.4.1 to 1.8.8 Nov 15, 2022
Comment on lines 24 to 28
if (WIN32)
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.2.3)
else()
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.4.1)
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.8.8)
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use different version on Windows and non-Windows platforms?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the answer to that question, but have another one: why did we need to change the Linux version but not the Windows version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, there was some problem with using newer loader + Windows GPU driver combination. I wonder if this problem still exists, or we can switch back to using the same loader version for all platforms.
@yanfeng3721, could you test v1.8.8 on Windows, please?

@againull
Copy link
Contributor

Basic/barrier_order.cpp is disabled for HIP backend - intel/llvm-test-suite#1376

@againull againull merged commit 01ac72d into intel:sycl Nov 15, 2022
@againull
Copy link
Contributor

@againull, is it okay to merge this PR? I see that you approved but haven't merged it.

Yes, it is ok to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants