-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL][PI][L0] Uplift L0 Loader from 1.4.1 to 1.8.8 #7381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Failed test is not related to current PR and due to #8798 |
@bader , could you please help to merge the PR? Thanks. |
@againull, is it okay to merge this PR? I see that you approved but haven't merged it. |
if (WIN32) | ||
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.2.3) | ||
else() | ||
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.4.1) | ||
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.8.8) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use different version on Windows and non-Windows platforms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the answer to that question, but have another one: why did we need to change the Linux version but not the Windows version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, there was some problem with using newer loader + Windows GPU driver combination. I wonder if this problem still exists, or we can switch back to using the same loader version for all platforms.
@yanfeng3721, could you test v1.8.8 on Windows, please?
Basic/barrier_order.cpp is disabled for HIP backend - intel/llvm-test-suite#1376 |
Yes, it is ok to merge this. |
No description provided.