[SYCL] Fix float-to-half conversion for minimum subnormal on host #7401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when converting a floating point value representing the minimum subnormal value for half to a half on host will result in 0 rather than the expected minimum value. This is due to a faulty check for the minimum supported single-precision exponent when converting. This commit fixes this check. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
added a commit
to steffenlarsen/llvm-test-suite
that referenced
this pull request
Nov 16, 2022
intel/llvm#7401 fixes host-side minimal subnormal half values, which in turn fixes generate_ref_conv_data in value_conv.hpp. This causes ctor_broadcast_fp_extra to unexpectedly pass. This commit enables ctor_broadcast_fp_extra. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1387 |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
added a commit
to intel/llvm-test-suite
that referenced
this pull request
Nov 18, 2022
intel/llvm#7401 fixes host-side minimal subnormal half values, which in turn fixes generate_ref_conv_data in value_conv.hpp. This causes ctor_broadcast_fp_extra to unexpectedly pass. This commit enables ctor_broadcast_fp_extra. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…est-suite#1387) intel#7401 fixes host-side minimal subnormal half values, which in turn fixes generate_ref_conv_data in value_conv.hpp. This causes ctor_broadcast_fp_extra to unexpectedly pass. This commit enables ctor_broadcast_fp_extra. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when converting a floating point value representing the minimum subnormal value for half to a half on host will result in 0 rather than the expected minimum value. This is due to a faulty check for the minimum supported single-precision exponent when converting. This commit fixes this check.