This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Enable ctor_broadcast_fp_extra ESIMD test #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel/llvm#7401 fixes host-side minimal subnormal half values, which in turn fixes generate_ref_conv_data in value_conv.hpp. This causes ctor_broadcast_fp_extra to unexpectedly pass. This commit enables ctor_broadcast_fp_extra. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm#7401 |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm#7401 |
v-klochkov
approved these changes
Nov 16, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
intel/llvm#7401 fixes host-side minimal subnormal half values, which in turn fixes generate_ref_conv_data in value_conv.hpp. This causes ctor_broadcast_fp_extra to unexpectedly pass. This commit enables ctor_broadcast_fp_extra. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…est-suite#1387) intel#7401 fixes host-side minimal subnormal half values, which in turn fixes generate_ref_conv_data in value_conv.hpp. This causes ctor_broadcast_fp_extra to unexpectedly pass. This commit enables ctor_broadcast_fp_extra. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm#7401 fixes host-side minimal subnormal half values, which in turn fixes generate_ref_conv_data in value_conv.hpp. This causes ctor_broadcast_fp_extra to unexpectedly pass. This commit enables ctor_broadcast_fp_extra.
Test still fails on Windows.