[SYCL] Add sycl-single-task implict property on single_task #8190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the "sycl-single-task" LLVM IR attribute to all SYCL kernels originating from single_task calls. Leveraging the existing mechanism for creating attributes for the SYCL kernel compile-time properties extension, applying the add_ir_attributes_function to SYCL kernel wrappers, this new attribute acts like a kernel compile-time property. To avoid this implicit attribute from causing property/attribute conflict warnings, a special rule is made in the frontend to skip the conflict check if it is the only value in the add_ir_attributes_function attribute. Additionally, this commit adds special handling of "sycl-single-task" when targeting "spir64_fpga", in which case it will cause a "max_global_work_dim" metadata node to be created with value "0" on functions where it is present. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
premanandrao
reviewed
Feb 3, 2023
| @@ -8007,10 +8007,23 @@ static bool checkSYCLAddIRAttributesMergeability(const AddIRAttrT &NewAttr, | |||
|
|
|||
| void Sema::CheckSYCLAddIRAttributesFunctionAttrConflicts(Decl *D) { | |||
| const auto *AddIRFuncAttr = D->getAttr<SYCLAddIRAttributesFunctionAttr>(); | |||
| if (!AddIRFuncAttr || AddIRFuncAttr->args_size() == 0 || | |||
| if (!AddIRFuncAttr || | |||
| hasDependentExpr(AddIRFuncAttr->args_begin(), AddIRFuncAttr->args_size())) | |||
| return; | |||
|
|
|||
There was a problem hiding this comment.
Could you please add a comment here about what this computation does?
There was a problem hiding this comment.
Good shout. I have added some comments to the skip criteria.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Fznamznon
reviewed
Feb 8, 2023
clang/lib/Sema/SemaDeclAttr.cpp
Outdated
| if (NumArgsWithoutFilter == 0) | ||
| return; | ||
|
|
||
| // "sycl-single-task" is an implicitly used name which is present on all |
There was a problem hiding this comment.
Did I get it right that here under "implicit" actually meant "explicit" (i.e. written in code explicitly) but it happens in SYCL implementation code, so for an end user this is still "implicit"?
There was a problem hiding this comment.
Right! Implicit from the perspective of the user, but explicit inside the SYCL headers. I have clarified this in the comment.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Fznamznon
approved these changes
Feb 8, 2023
smanna12
reviewed
Feb 8, 2023
clang/test/SemaSYCL/attr-add-ir-attributes-function-conflict.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
elizabethandrews
approved these changes
Feb 9, 2023
smanna12
approved these changes
Feb 9, 2023
elizabethandrews
requested changes
Feb 9, 2023
elizabethandrews
approved these changes
Feb 22, 2023
|
@intel/llvm-reviewers-runtime & @intel/dpcpp-tools-reviewers - Friendly ping. |
sarnex
approved these changes
Feb 24, 2023
|
@intel/llvm-reviewers-runtime - Friendly ping. |
1 similar comment
|
@intel/llvm-reviewers-runtime - Friendly ping. |
cperkinsintel
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the "sycl-single-task" LLVM IR attribute to all SYCL kernels originating from single_task calls. Leveraging the existing mechanism for creating attributes for the SYCL kernel compile-time properties extension, applying the add_ir_attributes_function to SYCL kernel wrappers, this new attribute acts like a kernel compile-time property.
To avoid this implicit attribute from causing property/attribute conflict warnings, a special rule is made in the frontend to skip the conflict check if it is the only value in the add_ir_attributes_function attribute.
Additionally, this commit adds special handling of "sycl-single-task" when targeting "spir64_fpga", in which case it will cause a "max_global_work_dim" metadata node to be created with value "0" on functions where it is present.