Skip to content

[SYCL][NFC] Fix unused StreamName argument #8607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2023
Merged

[SYCL][NFC] Fix unused StreamName argument #8607

merged 1 commit into from
Mar 10, 2023

Conversation

dm-vodopyanov
Copy link
Contributor

Logs: https://github.com/intel/llvm/actions/runs/4382801939/jobs/7672271805

/home/runner/work/llvm/llvm/src/sycl/unittests/xpti_trace/xptitest_subscriber/XPTISubscriber.cpp:47:50: error: unused parameter 'StreamName' [-Werror,-Wunused-parameter]
                                     const char *StreamName) {
                                                 ^
/home/runner/work/llvm/llvm/src/sycl/unittests/xpti_trace/xptitest_subscriber/XPTISubscriber.cpp:52:52: error: unused parameter 'StreamName' [-Werror,-Wunused-parameter]
XPTI_CALLBACK_API void xptiTraceFinish(const char *StreamName) {}
                                                   ^

@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner March 10, 2023 10:14
@dm-vodopyanov dm-vodopyanov requested a review from againull March 10, 2023 10:14
@dm-vodopyanov
Copy link
Contributor Author

@intel/llvm-reviewers-runtime can you please review as soon as possible? It fixes post-commit.

@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 10, 2023 10:39 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova mentioned this pull request Mar 10, 2023
Closed
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 10, 2023 11:17 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen merged commit f206ad6 into intel:sycl Mar 10, 2023
@dm-vodopyanov
Copy link
Contributor Author

@KseniyaTikhomirova this fix unblocked two failures in post-commit: https://github.com/intel/llvm/actions/runs/4384065640/jobs/7675082105

Can you please take a look?

Failed Tests (2):
  SYCL-Unit :: xpti_trace/./XptiTraceTests/QueueApiFailures/QueueFill
  SYCL-Unit :: xpti_trace/./XptiTraceTests/QueueApiFailures/QueuePrefetch

@KseniyaTikhomirova
Copy link
Contributor

@KseniyaTikhomirova this fix unblocked two failures in post-commit: https://github.com/intel/llvm/actions/runs/4384065640/jobs/7675082105

Can you please take a look?

Failed Tests (2):
  SYCL-Unit :: xpti_trace/./XptiTraceTests/QueueApiFailures/QueueFill
  SYCL-Unit :: xpti_trace/./XptiTraceTests/QueueApiFailures/QueuePrefetch

sure, thanks

@KseniyaTikhomirova
Copy link
Contributor

#8612 - to fix failures with clang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@againull againull Awaiting requested review from againull againull is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dm-vodopyanov @KseniyaTikhomirova @steffenlarsen