[SYCL][L0] Gracefully handle the case that L0 was already unloaded when we do cleanup #8948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
reviewed
Apr 4, 2023
| @@ -97,6 +97,8 @@ _PI_ERRC(PI_ERROR_INVALID_VA_API_MEDIA_ADAPTER_INTEL, -1098) | |||
| _PI_ERRC(PI_ERROR_INVALID_VA_API_MEDIA_SURFACE_INTEL, -1099) | |||
| _PI_ERRC(PI_ERROR_VA_API_MEDIA_SURFACE_ALREADY_ACQUIRED_INTEL, -1100) | |||
| _PI_ERRC(PI_ERROR_VA_API_MEDIA_SURFACE_NOT_ACQUIRED_INTEL, -1101) | |||
| // backend is lost, e.g. it was already unloaded | |||
There was a problem hiding this comment.
nit: UNITIALIZED seems suitable for other scenarios as well, like backend is not found, or a library is not system.
…en we do cleanup Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
againull
reviewed
Apr 5, 2023
Comment on lines
+627
to
+630
| auto ZeResult = ZE_CALL_NOCHECK(zeEventDestroy, (Event->ZeEvent)); | ||
| // Gracefully handle the case that L0 was already unloaded. | ||
| if (ZeResult && ZeResult != ZE_RESULT_ERROR_UNINITIALIZED) | ||
| return mapError(ZeResult); |
There was a problem hiding this comment.
NIT: Does it make sense to create another macro like ZE_CALL/ZE_CALL_NOCHECK which will not fail in case of ZE_RESULT_ERROR_UNINITIALIZED to use it in finalize/release functions?
There was a problem hiding this comment.
I don't think so, it's very limited in number of uses and there are cases where you still need to do smth besides destroying L0 handles, e.g. https://github.com/intel/llvm/pull/8948/files#diff-15dd1eb076d2164bd9e87d9057f05f652a716498e8cdf5975e564c65309a0985R7438
againull
approved these changes
Apr 5, 2023
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
…en we do cleanup (intel#8948) Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.