Skip to content

[SYCL][ESIMD] Add SYCL2020 spec constant redefinition test #9028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2023
Merged

[SYCL][ESIMD] Add SYCL2020 spec constant redefinition test #9028

merged 3 commits into from
Apr 12, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Apr 11, 2023

@sarnex
[SYCL][ESIMD] Add SYCL2020 spec constant redefinition test
e049072 
Based on https://github.com/intel/llvm-test-suite/blob/53b6f5b10c8235a7da625de81f2f2c77bd898e63/SYCL/DeprecatedFeatures/ESIMD/spec_const_redefine_esimd.cpp with changes:
1) Use SYCL2020 spec constants
2) Redefine the spec constants during the test

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex temporarily deployed to aws April 11, 2023 18:21 — with GitHub Actions Inactive
@sarnex sarnex marked this pull request as ready for review April 11, 2023 18:30
@sarnex sarnex requested a review from a team as a code owner April 11, 2023 18:30
v-klochkov
v-klochkov reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have only 1 comment.

@sarnex @v-klochkov
review feedback
0dcd601 
Co-authored-by: Vyacheslav Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
v-klochkov approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The _esimd in the name of the test seems redundant because the test is already in ESIMD folder

@sarnex
Copy link
Contributor Author

sarnex commented Apr 11, 2023

nit: The _esimd in the name of the test seems redundant because the test is already in ESIMD folder

ah yeah ill fix, thx

@sarnex
rename test
bea0e69 
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex temporarily deployed to aws April 11, 2023 20:35 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to aws April 11, 2023 22:26 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor Author

sarnex commented Apr 12, 2023 

********************
Failed Tests (1):
  SYCL :: Plugin/level_zero_imm_cmdlist_per_thread.cpp

********************
Unexpectedly Passed Tests (1):
  SYCL :: ESIMD/thread_id_test.cpp


********************
Failed Tests (1):
  SYCL :: Basic/memory-consumption.cpp

And ESIMD Emu

All unrelated

@intel/llvm-gatekeepers Can we merge? Thx!

@steffenlarsen
Copy link
Contributor

Given the new test is marked as unsupported for ESIMD Emu and it doesn't fail on L0 CI, it should be good to merge.

@steffenlarsen steffenlarsen merged commit d953ba3 into intel:sycl Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turinevgeny turinevgeny turinevgeny approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarnex @steffenlarsen @turinevgeny @v-klochkov