-
Notifications
You must be signed in to change notification settings - Fork 803
[SYCL][E2E] Substitute paths to lit tool binaries #9041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@aelovikov-intel might be of interest to you again. |
Hmm, I now see that pre-built tools should already be picked up in tests by this line:
but later on in the cfg we still have manual checks and warnings for |
040ff84
to
d0d7099
Compare
d0d7099
to
bc4a122
Compare
This change makes LIT explicitly substitute uses of tool binaries in tests with their full paths. This makes test RUN lines easier to reproduce, as it negates the effect of lit's internal environment (e.g., PATH) on which tools are run. The list of tools affected are: sycl-ls llvm-spirv, llvm-link, FileCheck and not (when used after a pipe). This also changes the behaviour of how LIT finds sycl-ls, llvm-spirv, and llvm-link. Whereas before these tools were found only on the PATH, now they will be preferably sourced first from the in-tree tools directory.
bc4a122
to
92e7ad8
Compare
I'm not sure if it's normal to wait over 6 hours for an AMGPU runner but rebasing this PR looks to have squashed all of the failures we were previously seeing. |
@intel/llvm-gatekeepers , this PR is ready. |
This change makes LIT explicitly substitute uses of tool binaries in
tests with their full paths. This makes test RUN lines easier to
reproduce, as it negates the effect of lit's internal environment (e.g.,
PATH) on which tools are run.
The list of tools affected are: sycl-ls llvm-spirv, llvm-link, FileCheck
and not (when used after a pipe).
This also changes the behaviour of how LIT finds sycl-ls, llvm-spirv,
and llvm-link. Whereas before these tools were found only on the PATH,
now they will be preferably sourced first from the in-tree tools
directory.