Skip to content

Conversation

yanfeng3721
Copy link
Contributor

Reverts #8952
Try resubmit #8851

@yanfeng3721 yanfeng3721 temporarily deployed to aws April 13, 2023 08:18 — with GitHub Actions Inactive
@yanfeng3721 yanfeng3721 temporarily deployed to aws April 13, 2023 08:54 — with GitHub Actions Inactive
@yanfeng3721 yanfeng3721 marked this pull request as ready for review April 14, 2023 08:08
@yanfeng3721 yanfeng3721 requested a review from a team as a code owner April 14, 2023 08:08
@yanfeng3721
Copy link
Contributor Author

yanfeng3721 commented Apr 14, 2023

@cperkinsintel , test result shows "All checks have passed". Is there any risk if the PR merged again? If no,
could you please help to monitor all PR's pre commit test status once the PR merged? Thanks.

Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cperkinsintel
Copy link
Contributor

@bader the first version of this PR passed earlier this week but then was determined to have caused CI failures after merging and was reverted. When I looked at the logs the failures were all network related ( "rate limit exceeded" ), making me think it might have been coincidental timing . Now I can't even find them.
I asked yan feng to resubmit the PR, which he has done, and, again, it's all passing. How should we proceed?

@yanfeng3721
Copy link
Contributor Author

@bader is there any blocker to merge the uplift PR? Thanks.

@stdale-intel stdale-intel merged commit 0ce9b5f into sycl Apr 24, 2023
@bader bader deleted the revert-8952-revert-8851-uplift_ocl_cpu_fpgaemu_rt branch May 5, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants