Skip to content

[SYCL] Add simple abs(int) to imf libdevice #9116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2023
Merged

[SYCL] Add simple abs(int) to imf libdevice #9116

merged 3 commits into from
Apr 25, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Apr 19, 2023

This PR aims to add a simple "int32_t abs(int32_t)" to imf libdevice. The request is from DL framework developers.

@jinge90
[SYCL] Add __devicelib_imf_abs to imf libdevice
f074ec0 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 requested review from a team as code owners April 19, 2023 05:20
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 19, 2023

Hi, @zettai-reido and @akolesov-intel
Could you take a look at this PR?
Thanks very much.

@jinge90
add __imf_abs to builtin header
9924faf 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to aws April 19, 2023 05:44 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws April 19, 2023 06:16 — with GitHub Actions Inactive
zettai-reido
zettai-reido approved these changes Apr 19, 2023
View reviewed changes
Copy link

@zettai-reido zettai-reido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Usually, abs is defined >= 0 to be x.

AlexeySachkov
AlexeySachkov approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl-post-link changes LGTM

@jinge90
update abs def
947471e 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 temporarily deployed to aws April 19, 2023 08:40 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws April 19, 2023 09:12 — with GitHub Actions Inactive
akolesov-nv
akolesov-nv approved these changes Apr 19, 2023
View reviewed changes
Copy link

@akolesov-nv akolesov-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jinge90
Copy link
Contributor Author

jinge90 commented Apr 20, 2023

Hi, @intel/llvm-reviewers-runtime and @cperkinsintel
Could you take a look at this simple patch?
Thanks very much.

@jinge90 jinge90 requested a review from a team April 21, 2023 00:46
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 21, 2023

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Apr 25, 2023

Hi, @intel/llvm-gatekeepers
Kind ping~

@stdale-intel stdale-intel merged commit 2a3aaee into intel:sycl Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@zettai-reido zettai-reido zettai-reido approved these changes

+1 more reviewer

@akolesov-nv akolesov-nv akolesov-nv approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jinge90 @cperkinsintel @AlexeySachkov @akolesov-nv @zettai-reido @stdale-intel