Skip to content

[SYCL] Implement info::device::backend_version for Level Zero, OpenCL and HIP #9205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 2, 2023
Merged

[SYCL] Implement info::device::backend_version for Level Zero, OpenCL and HIP #9205

merged 10 commits into from
May 2, 2023

Conversation

dm-vodopyanov
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov commented Apr 25, 2023 •
edited
Loading

This patch implements info::device::backend_version query for Level Zeroб OpenCL and HIP plugins.

+ some small unrelated typo fixed.

@dm-vodopyanov
[SYCL] Implement info::device::backend_version for Level Zero and OpenCL
9bd5449 
This patch implements info::device::backend_version query for Level Zero
and OpenCL as it stated in Table 25 of SYCL 2020 spec.
@dm-vodopyanov dm-vodopyanov requested review from a team as code owners April 25, 2023 13:56
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 25, 2023 14:54 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 25, 2023 16:45 — with GitHub Actions Inactive
smaslov-intel
smaslov-intel reviewed Apr 25, 2023
View reviewed changes
@smaslov-intel
Copy link
Contributor

This patch implements info::device::backend_version query for Level Zero and OpenCL as it stated in Table 25 of SYCL 2020 spec.

how is it stated there?

@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 27, 2023 16:37 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner April 27, 2023 16:56
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 27, 2023 17:03 — with GitHub Actions Inactive
gmlueck
gmlueck reviewed Apr 27, 2023
View reviewed changes
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 27, 2023 19:17 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 27, 2023 22:25 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 27, 2023 23:27 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 28, 2023 06:12 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 28, 2023 07:32 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 28, 2023 07:33 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 28, 2023 08:46 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 28, 2023 10:22 — with GitHub Actions Inactive
smaslov-intel
smaslov-intel reviewed Apr 28, 2023
View reviewed changes
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 28, 2023 17:04 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 28, 2023 18:14 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov requested a review from jbrodman May 1, 2023 11:24
@dm-vodopyanov dm-vodopyanov changed the title [SYCL] Implement info::device::backend_version for Level Zero and OpenCL [SYCL] Implement info::device::backend_version for Level Zero, OpenCL and HIP May 1, 2023
steffenlarsen
steffenlarsen approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit df743a5 into intel:sycl May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov left review comments

@jbrodman jbrodman jbrodman approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@gmlueck gmlueck Awaiting requested review from gmlueck

+3 more reviewers

@jandres742 jandres742 jandres742 left review comments

@bmyates bmyates bmyates left review comments

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dm-vodopyanov @smaslov-intel @jbrodman @gmlueck @AlexeySachkov @jandres742 @bmyates @steffenlarsen