[SYCL][Bindless] Add experimental implementation of bindless images extension #9665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges extension Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Hugh Bird <hugh.bird@codeplay.com> Co-authored-by: Duncan Brawley <duncan.brawley@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com> Co-authored-by: Chedy Najjar <chedy.najjar@codeplay.com> Co-authored-by: Sean Stirling <sean.stirling@codeplay.com> Co-authored-by: Peter Zuzek <peter@codeplay.com> Implement revision 3 of the bindless images extension proposal: https://github.com/intel/llvm/blob/8a48106617a9e2365c1935302d20e53bc7174368/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images/sycl_ext_oneapi_bindless_images.asciidoc
alycm
reviewed
May 31, 2023
| @@ -126,6 +126,7 @@ _PI_API(piEnqueueMemUnmap) | |||
| _PI_API(piextUSMHostAlloc) | |||
| _PI_API(piextUSMDeviceAlloc) | |||
| _PI_API(piextUSMSharedAlloc) | |||
| _PI_API(piextUSMPitchedAlloc) | |||
There was a problem hiding this comment.
Discussed this internally with the team, but to make the point visible to all reviewers: As this PR changes PI then it will require Unified Runtime changes to match this.
Documentation on how to add experimental features is being written here oneapi-src/unified-runtime#546
You can ask us (@alycm, @jandres742, @kbenzie) any questions and we'll help you out.
You can also see in-progress work of another experimental change (not even a draft PR yet) here: Bensuo/unified-runtime#1. The YAML changes are where to look first, a lot of the rest is autogenerated from that.
|
Can this PR be closed now that we've moved to split PRs (#9808)? |
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 28, 2023
…s images extension (#9808) This PR stands as the first PR of four to make code review easier, covering the changes made to libclc. See the original whole [PR](#9665). This is the first part of the implementation of revision 3 of the [bindless images extension proposal](https://github.com/intel/llvm/blob/8a48106617a9e2365c1935302d20e53bc7174368/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images/sycl_ext_oneapi_bindless_images.asciidoc). --------- Co-authored-by: SYCL Unbound Team <sycl.unbound@codeplay.com> Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Hugh Bird <hugh.bird@codeplay.com> Co-authored-by: Duncan Brawley <duncan.brawley@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com> Co-authored-by: Chedy Najjar <chedy.najjar@codeplay.com> Co-authored-by: Sean Stirling <sean.stirling@codeplay.com> Co-authored-by: Peter Zuzek <peter@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Isaac Ault isaac.ault@codeplay.com
Co-authored-by: Hugh Bird hugh.bird@codeplay.com
Co-authored-by: Duncan Brawley duncan.brawley@codeplay.com
Co-authored-by: Przemek Malon przemek.malon@codeplay.com
Co-authored-by: Chedy Najjar chedy.najjar@codeplay.com
Co-authored-by: Sean Stirling sean.stirling@codeplay.com
Co-authored-by: Peter Zuzek peter@codeplay.com
Implement revision 3 of the bindless images extension proposal: https://github.com/intel/llvm/blob/8a48106617a9e2365c1935302d20e53bc7174368/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images/sycl_ext_oneapi_bindless_images.asciidoc