-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add function to map Windows System Info to Windows Flavour with… #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds a new utility function to map Windows system information to Windows flavors, extending the existing kernel-only mapping functionality to handle cases where multiple Windows flavors share the same kernel version.
- Added
get_windows_version_from_system_info
function that uses both kernel version and OS name to determine Windows flavor - Updated imports to include
SystemInfo
class - Added comprehensive unit tests covering all code paths including success cases, invalid kernels, and unknown versions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
mfd_typing/utils.py | Added new function for system info mapping and updated imports |
tests/unit/test_mfd_typing/test_utils.py | Added unit tests for the new function covering all scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a0617c9
to
03bc849
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
5306582
to
941e31a
Compare
… tests Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lasota, Adrian <adrian.lasota@intel.com>
941e31a
to
7989c73
Compare
We don't publish DEVs .whl. |
This pull request adds a new utility function to map Windows system information to a Windows version and introduces comprehensive unit tests for this functionality. The changes also include a minor import update to support the new logic.
New functionality for Windows version mapping:
get_windows_version_from_system_info
inutils.py
to map aSystemInfo
object (containing kernel version and OS name) to aWindowsFlavour
enum, with error handling for unknown or invalid kernel versions.utils.py
to includeSystemInfo
for the new functionality.Testing improvements:
test_utils.py
to cover all major code paths ofget_windows_version_from_system_info
, including successful mappings, invalid kernel versions, and unknown kernel versions.test_utils.py
to support new tests.