Improve MXNet integration #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel#12) * Fix the graph optimization bug that inputs/outputs field is not optional. Signed-off-by: Zhang, Guoming <guoming.zhang@intel.com> * Add postfix.
intel#16) * Fix the graph optimization issue that setting precision to bf16 led crash on non-avx512-bf16 enabled platform. * Enhance the graph optimization by sorting the specified precisions. * Update the doc. Co-authored-by: Tian, Feng <feng.tian@intel.com>
Signed-off-by: Deb Taylor <deb.taylor@intel.com> Reviewed-by: Feng Tian <feng.tian@intel.com> Co-authored-by: Deb Taylor <deb.taylor@intel.com>
Signed-off-by: Deb Taylor <deb.taylor@intel.com> Reviewed-by: Feng Tian <feng.tian@intel.com> Co-authored-by: Deb Taylor <deb.taylor@intel.com>
…dd_source_suffix'
Proposition of yaml structure for MXNet
| 'int8': { | ||
| '_sg_mkldnn_conv': { | ||
| 'activation': { | ||
| 'dtype': ['int8', 'fp32'], |
There was a problem hiding this comment.
Would it be possible to add "autoint8" to the possible values of "dtype" attribute, which would correspond to the automatic selection of dtype according to the calibration result of each tensor?
Suggested change
| 'dtype': ['int8', 'fp32'], | |
| 'dtype': ['autoint8', 'fp32'], |
This way we could describe more clearly what is actually happening in MXNet.
ftian1
force-pushed
the
master
branch
2 times, most recently
from
42ec628 to
4939eb6
Compare
VincyZhang
added a commit
that referenced
this pull request
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improving MXNet integration. This change will focus on improving the current features.
Motivation
Changes
In mxnet.yaml:
In mxnet.py:
Please review the structure of my 1.9.0 configuration and decide whether this can be applied to the rest of the yaml file.