Skip to content

Conversation

XuehaoSun
Copy link
Contributor

@XuehaoSun XuehaoSun commented Sep 29, 2025

User description

Type of Change

feature or bug fix or documentation or validation or others
API changed or not

Description

detail description

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed


PR Type

Enhancement


Description

  • Added beautifulsoup4 dependency for unit tests

Diagram Walkthrough

flowchart LR
  A["Add beautifulsoup4"] -- "to run scripts" --> B["Unit Test Scripts"]
Loading

File Walkthrough

Relevant files
Enhancement
run_3x_pt.sh
Add beautifulsoup4 to run_3x_pt.sh                                             

.azure-pipelines/scripts/ut/3x/run_3x_pt.sh

  • Added beautifulsoup4==4.13.5 installation
+1/-0     
run_3x_pt_fp8.sh
Add beautifulsoup4 to run_3x_pt_fp8.sh                                     

.azure-pipelines/scripts/ut/3x/run_3x_pt_fp8.sh

  • Added beautifulsoup4==4.13.5 installation
+1/-0     
run_3x_tf.sh
Add beautifulsoup4 to run_3x_tf.sh                                             

.azure-pipelines/scripts/ut/3x/run_3x_tf.sh

  • Added beautifulsoup4==4.13.5 installation
+1/-0     

Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
@PRAgent4INC
Copy link
Collaborator

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Dependency Version

The version of beautifulsoup4 is hardcoded. Consider using a more flexible version specifier to allow for minor updates without requiring a PR.

pip install beautifulsoup4==4.13.5
Dependency Version

The version of beautifulsoup4 is hardcoded. Consider using a more flexible version specifier to allow for minor updates without requiring a PR.

pip install beautifulsoup4==4.13.5
Dependency Version

The version of beautifulsoup4 is hardcoded. Consider using a more flexible version specifier to allow for minor updates without requiring a PR.

pip install beautifulsoup4==4.13.5

@PRAgent4INC
Copy link
Collaborator

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Update beautifulsoup4 version

Consider using a more recent version of beautifulsoup4 to benefit from the latest
features and security updates.

.azure-pipelines/scripts/ut/3x/run_3x_pt.sh [19]

-pip install beautifulsoup4==4.13.5
+pip install beautifulsoup4
Suggestion importance[1-10]: 5

__

Why: Updating to the latest version of beautifulsoup4 can provide new features and security updates, but it may also introduce breaking changes. This suggestion is moderate in impact and relevance.

Low

@XuehaoSun XuehaoSun merged commit 4ecf8ca into master Sep 29, 2025
12 of 20 checks passed
@XuehaoSun XuehaoSun deleted the xuehao/fix_ut branch September 29, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants