Fix failing dimension check for MAX operation. #566
Merged
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitm3k
force-pushed
the
ovep-develop
branch
from
e43cdb3 to
fb6bdee
Compare
|
@saurabhkale17 please review |
javier-intel
force-pushed
the
ovep-develop
branch
from
cd89be3 to
ade3b59
Compare
|
@saurabhkale17 @rayngun PR is unblocked now, Please rebase and ready to merge. Please finish review process. |
|
@rayngun Can you please rebase the branch |
* update: Update MSFT Contrib Ops from OV * modified data_ops.cc to remove unsupported ops * disabled tests for EmbedLayerNormalisation and MatMulNBits --------- Co-authored-by: n1harika <niharika.sathish@intel.com>
sfatimar
force-pushed
the
ovep-develop
branch
from
059f7c1 to
f84614c
Compare
|
LGTM. |
ankitm3k
force-pushed
the
ovep-develop
branch
from
5e0f026 to
781f620
Compare
|
Internal CI is failing @jatinwadhwa921 I am merging anyways as it is open for long time. |
ankitm3k
added a commit
that referenced
this pull request
Feb 17, 2025
* Internal ci for PTL 1.1 (#523) * update: Update MSFT Contrib Ops in OVEP (#521) * update: Update MSFT Contrib Ops from OV * modified data_ops.cc to remove unsupported ops * disabled tests for EmbedLayerNormalisation and MatMulNBits --------- Co-authored-by: n1harika <niharika.sathish@intel.com> * Add Max op to no_dimension_supported list --------- Co-authored-by: jatinwadhwa921 <110383850+jatinwadhwa921@users.noreply.github.com> Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com> Co-authored-by: n1harika <niharika.sathish@intel.com>
ankitm3k
added a commit
that referenced
this pull request
Feb 17, 2025
* Internal ci for PTL 1.1 (#523) * update: Update MSFT Contrib Ops in OVEP (#521) * update: Update MSFT Contrib Ops from OV * modified data_ops.cc to remove unsupported ops * disabled tests for EmbedLayerNormalisation and MatMulNBits --------- Co-authored-by: n1harika <niharika.sathish@intel.com> * Add Max op to no_dimension_supported list --------- Co-authored-by: jatinwadhwa921 <110383850+jatinwadhwa921@users.noreply.github.com> Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com> Co-authored-by: n1harika <niharika.sathish@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.