Skip to content

Conversation

intbf
Copy link

@intbf intbf commented Oct 8, 2025

Description

In #817 we assumed that initializers's size is larger than zero. This is not the case for some models. While Initializers with RAW data usually works, as OV can skip them, there was an issue when we converted those initializers with RAW data to initializers with EXT data in memory.
So it's safe to add this check on the OVEP side (later we'll try to improve OpenVino side as well, and double check with their implementation)

Motivation and Context

CVS-174653

Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
@MayureshV1 MayureshV1 requested a review from Copilot October 8, 2025 21:29
Copy link

@MayureshV1 MayureshV1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a regression in model PSS and PSR by adding a safety check for zero-size initializers before calling SetExternalDataFields. Previously, the code assumed all initializers had non-zero size, but some models contain empty initializers that caused issues when converting RAW data to EXT data in memory.

  • Added size validation check before calling SetExternalDataFields
  • Added verbose logging for empty initializers that are skipped
  • Prevents issues with zero-size initializers in OpenVino execution provider

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@MayureshV1 MayureshV1 merged commit d102554 into intel:ovep-develop Oct 9, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants