Skip to content

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Mar 17, 2021

GitHub's ubuntu-latest runner uses Ubuntu 20.04 whereas previously it used Ubuntu 18.04. As a result, several dependencies must change

  • libusb has a different name
  • opencv uses the 4.x branch (previously 3.2)

@abrown abrown force-pushed the update-runners branch 2 times, most recently from d475ac2 to 315ceef Compare March 17, 2021 19:18
@abrown
Copy link
Contributor Author

abrown commented Mar 27, 2021

Re-enabling the redundant move ignore because of:

    Called from: [1]	/home/runner/work/openvino-rs/openvino-rs/crates/openvino-sys/upstream/inference-engine/ie_bridges/c/samples/object_detection_sample_ssd/CMakeLists.txt
  /home/runner/work/openvino-rs/openvino-rs/crates/openvino-sys/upstream/inference-engine/thirdparty/ade/sources/ade/source/execution_engine.cpp: In member function ‘std::unique_ptr<ade::Executable> ade::ExecutionEngine::createExecutable(const ade::Graph&)’:
  /home/runner/work/openvino-rs/openvino-rs/crates/openvino-sys/upstream/inference-engine/thirdparty/ade/sources/ade/source/execution_engine.cpp:141:21: error: redundant move in return statement [-Werror=redundant-move]
    141 |     return std::move(ret);
        |            ~~~~~~~~~^~~~~
  /home/runner/work/openvino-rs/openvino-rs/crates/openvino-sys/upstream/inference-engine/thirdparty/ade/sources/ade/source/execution_engine.cpp:141:21: note: remove ‘std::move’ call
  cc1plus: all warnings being treated as errors
  make[3]: *** [inference-engine/thirdparty/ade/sources/ade/CMakeFiles/ade.dir/build.make:137: inference-engine/thirdparty/ade/sources/ade/CMakeFiles/ade.dir/source/execution_engine.cpp.o] Error 1
  make[2]: *** [CMakeFiles/Makefile2:3272: inference-engine/thirdparty/ade/sources/ade/CMakeFiles/ade.dir/all] Error 2
  make[2]: *** Waiting for unfinished jobs....
  make[1]: *** [CMakeFiles/Makefile2:3600: inference-engine/src/mkldnn_plugin/CMakeFiles/MKLDNNPlugin.dir/rule] Error 2
  make: *** [Makefile:1142: MKLDNNPlugin] Error 2
  thread 'main' panicked at '
  command did not execute successfully, got: exit code: 2

abrown added 2 commits March 26, 2021 18:59
GitHub's `ubuntu-latest` runner uses Ubuntu 20.04 whereas previously it used Ubuntu 18.04. As a result, several dependencies must change
 - libusb has a different name
 - opencv uses the 4.x branch (previously 3.2)
GCC 9 moves the `-Wno-redundant-move` flag from a warning to an error. Newer OS releases, such as Ubuntu 20.04, provide GCC 9+ so building from source is broken. This change ignores redundant moves; fixes intel#8.
@abrown abrown marked this pull request as ready for review March 27, 2021 02:06
@abrown
Copy link
Contributor Author

abrown commented Mar 27, 2021

@grgustaf, it would nice to see if you need anything else from this PR before merging. Do you want to test out this branch on your machine or merge it first?

@grgustaf
Copy link
Contributor

LGTM

@abrown abrown merged commit 275606e into intel:main Mar 29, 2021
@abrown abrown deleted the update-runners branch March 29, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants