Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

XDG-shell: Minimize works once only #258

Closed
tiagovignatti opened this issue Jul 29, 2014 · 3 comments
Closed

XDG-shell: Minimize works once only #258

tiagovignatti opened this issue Jul 29, 2014 · 3 comments
Labels

Comments

@tiagovignatti
Copy link
Contributor

When using xdg shell, minimize works only once but not twice.

More specifically, if the user click/tap in the minimize icon of content_shell and then bring it back using super+tab, the next time minimize won't simply work.

The problem is in ui/desktop_aura/desktop_window_tree_host_wayland.cc. When click happens in minimize icon, Chromium code dispatches an event that will trigger views::DesktopWindowTreeHostWayland::Minimize(), consequently forward to GPU process a WLShellSurface::Minimize(). After going through the (Wayland) wire, Weston hides the window and the world is perfect. But when Weston triggers a switch back event (super+tab) to the client, nothing will be triggered in Chromium/Ozone-Wayland side to restore the visibility state again; it still thinks that the client is hidden. So we need to see what kind of method in DesktopWindowTreeHostWayland is called when this happen and fix the state_ flag behavior.

@nicoguyo
Copy link
Contributor

nicoguyo commented Aug 6, 2014

I think this should be done in HandleNativeWidgetActivationChanged method.
This method is called when window gain pointer focus.

IMHO this should be done when weston notifies window's surface is activated or gain keyboard focus.

@nicoguyo
Copy link
Contributor

nicoguyo commented Aug 8, 2014

PR 261 fix this issue: #261.

@kalyankondapally
Copy link
Contributor

Fixed.

shaochangbin pushed a commit to shaochangbin/ozone-wayland that referenced this issue Sep 4, 2014
Reset minimized status when activated_set event is received whereas window is minimized.
kalyankondapally pushed a commit that referenced this issue Sep 6, 2014
Reset minimized status when activated_set event is received whereas window is minimized.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants