This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Utility improvements #274
Closed
Utility improvements #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krocard
commented
Oct 9, 2015
krocard
commented
- asString now return the formated string leading to usage improvement
- Fully unit test Utility.h
- Simplify appendTitle implementation
- CommandHandler: simplify the message formating
-
General Comment
- <img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'> Close and reopen as Utility improvements #275 to fix branch name typo.
General Comment
asString was not returning it's result, leading to more complicated usage. Return the formated string instead of using an output parameter. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Utility functions were not tested, introduce unit tests for all functions in Utility.h. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Use `std::string::string(size_t, char)` to simplify the construction of the help message. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
|
Close and reopen as #275 to fix branch name typo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.