Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Conversation

dawagner
Copy link
Contributor

Add support to inport/export configurable element in binary format.

/** Access the element and descendant as bytes.
* @{
*/
...
/** @} */

   

@dawagner dawagner added this to the Version 3.1 milestone Oct 15, 2015
@dawagner dawagner mentioned this pull request Oct 15, 2015
5 tasks
@dawagner dawagner force-pushed the access-elements-as-binary branch 2 times, most recently from 9755652 to d098617 Compare October 15, 2015 11:47
@dawagner dawagner changed the title Access elements as binary [review] Access elements as binary Oct 16, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pParameterBlackboard blackboard temporary variable does not seem very usefull.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@dawagner dawagner force-pushed the access-elements-as-binary branch 2 times, most recently from af5fff6 to 1a0da14 Compare October 19, 2015 14:04
@dawagner
Copy link
Contributor Author

@krocard all comments addressed. Please review. @tcahuzax please review as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not realy get why this intermediate variable is usefull. But if you like it, keep it. It is a mater of style.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

This method returns a reference to the vector of all the arguments passed along
the remote command.

Signed-off-by: Miguel Gaio <miguel.gaio@intel.com>
@dawagner dawagner force-pushed the access-elements-as-binary branch from 1a0da14 to 933a633 Compare October 19, 2015 18:07
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function asserts that size + offset exceeds the size of the blackboard iself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@dawagner dawagner force-pushed the access-elements-as-binary branch from 933a633 to 7d7d55c Compare October 20, 2015 08:46
CParameterBlackboard class now exposes the following additional methods to
direclty access the blackboard memory a certain offset:
    - writeBytes()
    - readBytes()
Note that these methods are primarily intended to be used to access the
settings of an element.

Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
Signed-off-by: Miguel Gaio <miguel.gaio@intel.com>
Returns the element settings formatted as hexadecimal byte array

Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
Signed-off-by: Miguel Gaio <miguel.gaio@intel.com>
Allows assigning settings to a configurable element in byte array format.
Supports hexa or decimal formatting.
Notes:
    - Use with caution (low level command): checks for integrity are not
      performed prior to assignment.
    - Tuning Mode must be on

Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
Signed-off-by: Miguel Gaio <miguel.gaio@intel.com>
@krocard
Copy link
Contributor

krocard commented Oct 20, 2015

:shipit:

@tcahuzax
Copy link
Contributor

👍

krocard added a commit that referenced this pull request Oct 20, 2015
Access elements as binary

Add support to inport/export configurable element in binary format.
@krocard krocard merged commit 77a679c into intel:serialization_api Oct 20, 2015
@dawagner dawagner deleted the access-elements-as-binary branch October 20, 2015 13:19
@krocard krocard changed the title [review] Access elements as binary Access elements as binary Oct 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants