This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Fix show mapping segfault #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawagner
changed the title
dawagner
force-pushed
the
fix-showMapping-segfault
branch
from
f36b0ea to
81c3c75
Compare
Current coverage is
|
|
👎 |
parameter/Subsystem.cpp
Outdated
| } | ||
|
|
||
| return pSubsystemObject; | ||
| return NULL; |
dawagner
force-pushed
the
fix-showMapping-segfault
branch
from
81c3c75 to
f6e92d5
Compare
…ct found This function was improperly returning the latest candidate in case of failure instead of returning a nullptr. This led the caller to use the returned pointer even if it was not correct. Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
force-pushed
the
fix-showMapping-segfault
branch
2 times, most recently
from
2a0797e to
4d07de1
Compare
It was segfaulting due to an erroneous static_cast. Simplify the code related to showMapping by taking into account the fact that all ConfigurableElements may have a mapping (SystemClass currently doesn't have any but it can simply return an empty mapping). The leaf element is a special case because the instantiation mapping may be formatted using "amends" - other mappings may not. Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
added a commit
that referenced
this pull request
Feb 16, 2016
Fix a segfault in the showMapping command.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a segfault in the showMapping command.
80.09%