This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Don't leak asio headers from libremote-processor #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remote-processor/Socket.h
Outdated
| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
| #include <asio.hpp> | ||
| #include <utility> |
|
TODO: fix copyright dates. |
Current coverage is
|
dawagner
force-pushed
the
dont-leak-asio-headers
branch
2 times, most recently
from
c3e2a07 to
40f8d75
Compare
|
👍 |
dawagner
force-pushed
the
dont-leak-asio-headers
branch
2 times, most recently
from
472927e to
256977a
Compare
asio/stub/asio.cpp
Outdated
| bool read(const dummy_base &, const dummy_base &, const dummy_base &) | ||
| { | ||
| return true; | ||
| } |
Wrap some classes and forward-declare some others in other not to expose any asio object in the public interfaces. This means that client (such as libparameter) will now be completely unaware of asio. Signed-off-by: David Wagner <david.wagner@intel.com>
…tch class name Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
force-pushed
the
dont-leak-asio-headers
branch
from
256977a to
47deb4d
Compare
dawagner
changed the title
dawagner
force-pushed
the
dont-leak-asio-headers
branch
from
cf16f40 to
42472b7
Compare
We need CMake 3.x in order to have "interface" libraries (libs with no build instructions but useful for usage requirement forwarding of header-only libraries). Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
force-pushed
the
dont-leak-asio-headers
branch
from
42472b7 to
417bb00
Compare
|
|
Introduce an asio stub. In such a case, libremote-processor becomes useless but still acts as if it was working correctly. This is an easy way to have a version of libparameter that does not embed any networking code, which is required in some case for security compliance reasons. This can be achieved by turning the NETWORKING option OFF when configuring the CMake project. Signed-off-by: David Wagner <david.wagner@intel.com>
Compile-out test-platform and remote-process when NETWORKING==OFF. Also, have the Parameter Framework fail to start if the user requested the remote interface to be started but compiled networking support out at the same time. Signed-off-by: David Wagner <david.wagner@intel.com>
Explain how optional dependencies can be avoided. Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
force-pushed
the
dont-leak-asio-headers
branch
3 times, most recently
from
7e17e6c to
7c0b65b
Compare
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
krocard
added a commit
that referenced
this pull request
Feb 25, 2016
Make network dependency optional - Add cmake option NETWORKING to stub ASIO - If networking is requested (tunning allowed), the PF will fail to start - Require cmake 3.0.0 for asio stub INTERFACE lib. - If networking is off, remove the asio dependency. Internal: Don't leak asio headers from libremote-processor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make network dependency optional
Internal: Don't leak asio headers from libremote-processor.
FowardDecltemplate class in the utility lib?80.30%