This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Travis: enable OSX builds #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
@terahxluna please review |
|
👍 |
Some compilers complain when failing to use the `override` specifier when
overriding a method. clang-tidy can help automatically add it to relevant
methods. It also does a lot of cleanup by removing `virtual` when both
`virtual` and `override` are specified. Same with `override` and `final`: final
methods are implicitly overrides and thus makes the `override` specifier
redundant.
For reference, this was done with clang-tidy-3.8:
ls parameter/*cpp | xargs -n1 clang-tidy-3.8 \
-checks=modernize-use-override -fix -p=<path-to-build-dir> \
-header-filter=parameter
and CMake was ran with the `-DCMAKE_EXPORT_COMPILE_COMMANDS=1` option. Note the
use of xargs: when running clang-tidy on multiple files at once, strange things
happen and the files are left in state that wouldn't compile. clang-format also
needs to be run after clang-tidy.
Signed-off-by: David Wagner <david.wagner@intel.com>
Travis has OSX builders in addition to Linux builders. This commit enables some build steps on OSX builders. OSX has some differences with Linux, one important difference being how packages are installed. Current limitations that will be lifter later: - no tests (because some test code does not compile) - no client-simulator (because of issues in detecting the Python libraries) Signed-off-by: David Wagner <david.wagner@intel.com>
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let Travis CI run on OSX builders too.
80.30%@@ master #356 diff @@ ===================================== Files 211 211 Stmts 7184 7184 Branches 0 0 Methods 0 0 ===================================== Hit 5769 5769 Partial 0 0 Missed 1415 1415