Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Conversation

dawagner
Copy link
Contributor

@dawagner dawagner commented May 13, 2016

This reverts commit 0f759ae.

Some users expect enum parameters to be printed in "raw" form. This was removed
because it was thought to break serialization/deserialization bijection when
several enum parameters have the same numerical values. That case cannot be
handled anyway so this is a non-issue.

Signed-off-by: David Wagner david.wagner@intel.com

@@             master       #369   diff @@
==========================================
Files           211        211
Lines          7169       7181    +12
Methods        1309       1309
Messages          0          0
Branches       3244       3253     +9
==========================================
+ Hits           3461       3469     +8
+ Misses         1404       1401     -3
- Partials       2304       2311     +7

Powered by Codecov. Last updated by d7b718a...0b8bef7

  

@dawagner
Copy link
Contributor Author

@krocard @sguiriec Please review.

@sguiriec
Copy link

tested-by: "Sebastien Guiriec sebastien.guiriec@intel.com"

Working on Asus T100 with System Designer for Anudio tuning

@dawagner dawagner force-pushed the enum-parameter-raw branch from 0b8bef7 to 933a19d Compare May 17, 2016 08:44
@codecov-io
Copy link

codecov-io commented May 17, 2016

Current coverage is 48.31%

Merging #369 into master will increase coverage by <.01%

  1. File utility/convert.hpp (not in diff) was modified. more
  2. File ...er/ParameterType.cpp (not in diff) was modified. more
    • Misses -4
    • Partials 0
    • Hits +4
  3. File ...numParameterType.cpp was modified. more
@@             master       #369   diff @@
==========================================
  Files           211        211          
  Lines          7169       7181    +12   
  Methods        1309       1309          
  Messages          0          0          
  Branches       3244       3253     +9   
==========================================
+ Hits           3461       3469     +8   
+ Misses         1404       1401     -3   
- Partials       2304       2311     +7   

Powered by Codecov. Last updated by d7b718a...0b8bef7

This reverts commit 0f759ae.

Some users expect enum parameters to be printed in "raw" form. This was removed
because it was thought to break serialization/deserialization bijection when
several enum parameters have the same numerical values. That case cannot be
handled anyway so this is a non-issue.

Signed-off-by: David Wagner <david.wagner@intel.com>
@dawagner dawagner force-pushed the enum-parameter-raw branch from 933a19d to 7e786aa Compare May 17, 2016 08:51
@dawagner dawagner merged commit 2e2c57b into intel:master May 17, 2016
@dawagner dawagner deleted the enum-parameter-raw branch May 17, 2016 13:48

// Hexa display with unecessary bits cleared out
sstream << "0x" << std::hex << std::uppercase
<< std::setw(static_cast<int>(getSize() * 2)) << std::setfill('0')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this static cast is not useful. Or maybe only to go from unsigned to signed ?

@krocard
Copy link
Contributor

krocard commented May 17, 2016

Some users expect enum parameters to be printed in "raw" form.
This seem to imply that this change is a made only to satisfy users. Whereas the current behavior was indeed not consistent with other parameters.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants