This repository was archived by the owner on Aug 5, 2022. It is now read-only.
IntegerParameterType: Fix Min/Max XML import overflow #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case XML data for Min and Max values are wrongly set (out of range). The Import function is not checking out of range format. In order to avoid roll over some additional boundary check need to be done. For exemple if we have Sign integer on 8 bits and we set Max value to 200 the new code will initialize the Max value to 127. Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>
|
@dwagner please have a look related to boundary check. |
This patch is fixing code formating according to clang Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>
dawagner
reviewed
Sep 29, 2016
parameter/IntegerParameterType.cpp
Outdated
| type CIntegerParameterType::LimitValueAgainstRange(type value, | ||
| type minValue, type maxValue) const | ||
| { | ||
| if (value > maxValue) return(maxValue); |
There was a problem hiding this comment.
coding style:
if (condition) {
statement;
}
There was a problem hiding this comment.
As of today .xsd doesn't check the range. So this method allows to have same behavior as when we do not specify Min and Max.
In case of ERROR a tool should be provided in order to check XML mix/max range as I am not sure that the error will be explicit for a full platform XML loading.
parameter/IntegerParameterType.cpp
Outdated
|
|
||
| // Limit Range accoridng to dynammic | ||
| template <typename type> | ||
| type CIntegerParameterType::LimitValueAgainstRange(type value, |
There was a problem hiding this comment.
coding style: method names start with a lowercase letter.
Current coverage is 72.11% (diff: 88.46%)@@ master #375 diff @@
==========================================
Files 211 211
Lines 6683 6705 +22
Methods 1438 1439 +1
Messages 0 0
Branches 857 863 +6
==========================================
+ Hits 4814 4835 +21
+ Misses 1397 1396 -1
- Partials 472 474 +2
|
added 5 commits
September 29, 2016 13:45
In case XML Min/Max values are not well set the import is returning error. Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>
Minimum default value should be sign extended before boundary check. Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>
This patch is improving IntegerParameter Type unit tests in order to check Min/max boundary when it is possible. Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>
Due to Min and Max format storage the Size of Integer parameter should be limit to 32 bits. Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>
Enhance unit test in order to check data size above 32 bits. Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>
2 tasks
|
I've just merged #376, which covers the same issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case XML data for Min and Max values are wrongly set (out of range). The
Import function is not checking out of range format. In order to avoid
roll over some additional boundary check need to be done.
For exemple if we have Sign integer on 8 bits and we set Max value to 200
the new code will initialize the Max value to 127.
Signed-off-by: Sebastien Guiriec sebastien.guiriec@intel.com
