-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GitHub Codespaces configuration #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @chykon for this PR, this looks great! I was able to open your branch and it all looks good.
I think an "Open in GitHub Codespaces" badge would be a great addition to the README. If you like, you can add it to this PR, otherwise I will include it in another documentation-related PR that I'm working on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for your contribution!
@chykon, we really appreciate all the thought, time, and effort you've been putting into making ROHD and its repository better!
Description & Motivation
Thanks to contribution tried GitHub Codespaces along with ROHD. Pretty handy for certain situations. I would like to suggest some improvements:
Icarus Verilog
version 11 and increase container deployment time.updateContentCommand
when the container is created.public key
for the Dart repository is suggested to be stored locally, rather than downloaded each time the container is created.Separately, I would like to ask for opinions: is it necessary to automatically open files when starting codespace? Now the files
README.md
,CONTRIBUTING.md
,CODE_OF_CONDUCT.md
are opened. This should help new contributors, but it can also be annoying.Related Issue(s)
No.
Testing
You can check:
Backwards-compatibility
No.
Documentation
No, but it will be possible to add the GitHub Codespaces badge to
README.md
. Instructions here.